Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align error message punctuation to Terraform best practices #327

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

n/a

What to Check

Verify that the following are valid:

n/a

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the documentation Improvements or additions to documentation label Jul 25, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 25, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 25, 2023
@lechnerc77 lechnerc77 requested a review from rui1610 July 25, 2023 12:50
@lechnerc77 lechnerc77 linked an issue Jul 25, 2023 that may be closed by this pull request
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 25, 2023 12:50
@lechnerc77 lechnerc77 changed the title docu: align error message punctuation to Terraform best practices docs: align error message punctuation to Terraform best practices Jul 25, 2023
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.
And I love it how little things like good documentation and proper error messages give our Terraform provider a professional "look and feel". Thanks again for keeping an eye on the quality of our documentation.

@lechnerc77 lechnerc77 merged commit c3592c5 into main Jul 25, 2023
13 checks passed
@lechnerc77 lechnerc77 deleted the docu-error-messages branch July 25, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docu] Align error messages
2 participants