Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks #19327

Merged
merged 7 commits into from
Oct 17, 2024
Merged

fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks #19327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ed6d4b
fix: (CXSPA-8033) add aria hidden attribute tp 'required' asterisks
StanislavSukhanov Oct 3, 2024
76badd3
fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks
StanislavSukhanov Oct 7, 2024
a691380
fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks
StanislavSukhanov Oct 15, 2024
f8c94e4
Merge branch 'develop' into feature/CXSPA-8033-add-aria-hidden-to-req…
StanislavSukhanov Oct 17, 2024
8eb948a
Merge branch 'develop' into feature/CXSPA-8033-add-aria-hidden-to-req…
StanislavSukhanov Oct 17, 2024
bc8f984
Merge branch 'develop' into feature/CXSPA-8033-add-aria-hidden-to-req…
StanislavSukhanov Oct 17, 2024
7f855f4
Merge branch 'develop' into feature/CXSPA-8033-add-aria-hidden-to-req…
StanislavSukhanov Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions feature-libs/cart/base/components/cart-coupon/cart-coupon.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions ...bs/cart/quick-order/components/cart-quick-order-form/cart-quick-order-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<!-- TODO: (CXSPA-5953) Remove feature flags next major -->
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions ...s/cart/saved-cart/components/saved-cart-form-dialog/saved-cart-form-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
>{{ 'savedCartDialog.savedCartName' | cxTranslate }}
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions ...onents/checkout-payment-method/checkout-payment-form/checkout-payment-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
Expand Down
1 change: 1 addition & 0 deletions ...re-libs/checkout/base/components/checkout-place-order/checkout-place-order.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</a>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
6 changes: 6 additions & 0 deletions feature-libs/user/account/components/login-form/login-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

<form (ngSubmit)="onSubmit()" [formGroup]="form">
<!-- TODO: (CXSPA-5953) Remove feature flags next major -->
<p *cxFeature="'a11yRequiredAsterisks'" class="form-legend">
{{ 'formLegend.required' | cxTranslate }}
</p>
<label>
<span class="label-content">
{{ 'loginForm.emailAddress.label' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<input
required="true"
Expand Down Expand Up @@ -32,6 +36,7 @@
<label>
<span class="label-content">
{{ 'loginForm.password.label' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<input
required="true"
Expand Down Expand Up @@ -75,6 +80,7 @@
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
>
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/account/components/otp-login-form/otp-login-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/profile/components/address-book/address-form/address-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
10 changes: 10 additions & 0 deletions feature-libs/user/profile/components/forgot-password/forgot-password.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
<cx-spinner class="overlay" *ngIf="isUpdating$ | async"> </cx-spinner>
<!-- TODO: (CXSPA-5953) Remove feature flags next major -->
<p *cxFeature="'a11yRequiredAsterisks'" class="form-legend">
{{ 'formLegend.required' | cxTranslate }}
</p>
<form (ngSubmit)="onSubmit()" [formGroup]="form">
<label>
<span class="label-content"
>{{ 'forgottenPassword.emailAddress.label' | cxTranslate }}
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
>
</span>
<input
required="true"
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/profile/components/register/register.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/profile/components/update-email/update-email.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/profile/components/update-password/update-password.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/profile/components/update-profile/update-profile.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
1 change: 1 addition & 0 deletions ...ontlib/cms-components/product/product-tabs/product-reviews/product-reviews.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ <h3>{{ 'productReview.overallRating' | cxTranslate }}</h3>
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Loading