fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks #19327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanislavSukhanov
commented
Oct 3, 2024
StanislavSukhanov
commented
- closes https://jira.tools.sap/browse/CXSPA-8033
spartacus
|
||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 04m 28s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Pio-Bar
requested changes
Oct 4, 2024
Comment on lines
73
to
81
|
|
||
| <ng-template #requiredAsterisk> | ||
| <abbr | ||
| *cxFeature="'a11yRequiredAsterisks'" | ||
| class="text-decoration-none" | ||
| title="{{ 'common.required' | cxTranslate }}" | ||
| >*</abbr | ||
| > | ||
| </ng-template> |
There was a problem hiding this comment.
Good on you for cleaning it up, somebody must have left it here while removing the asterisks from the login page. 🤷
|
@Pio-Bar fixed. The 'required' is still being narrated. It's being picked up by an inputs required attribute. |
Pio-Bar
previously approved these changes
Oct 7, 2024
Zeyber
previously approved these changes
Oct 7, 2024
|
@StanislavSukhanov your solution works well on JAWS. Now, let's complete the auditor's full request, so please bring back the Login and Reset Password asterisk removed on CXSPA-7418 and apply your solution there as well. I have left a comment on that ticket explaining why we can't remove audited content. |
* moved aria-hidden to abbr tag. * The 'required' word is still being narrated by picking up input's required attribute * closes https://jira.tools.sap/browse/CXSPA-8033
* restored asterisks on ForgotPassword and LoginForm * closes https://jira.tools.sap/browse/CXSPA-8033
StanislavSukhanov
dismissed stale reviews from Pio-Bar and Zeyber
via
a691380
StanislavSukhanov
force-pushed
the
feature/CXSPA-8033-add-aria-hidden-to-required-asterisks
branch
from
9361c7f
to
a691380
Compare
|
@developpeurweb It's done. Please have a look on that once again 🙏 |
developpeurweb
approved these changes
Oct 16, 2024
StanislavSukhanov
deleted the
feature/CXSPA-8033-add-aria-hidden-to-required-asterisks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.