Simplify impl_array_size macro and add a value #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Feb 16, 2024
| $( | ||
| unsafe impl ArraySize for $ty { | ||
| type ArrayType<T> = [T; $len]; | ||
| type ArrayType<T> = [T; <$ty as Unsigned>::USIZE]; |
|
I noticed that, for whatever reason, this seems to have caused increased compile times. On my machine timing Notably this matters for expanding the number extra sizes we define. |
tarcieri
added a commit
that referenced
this pull request
Feb 25, 2024
Replaces the existing ad hoc array size selections with the following, which cover all current known use cases: - 0-256 - 272-1024 (multiples of 16) - 1040-4096 (multiples of 32) This also effectively reverts #50, since it was adding considerably to compile times (now noted as a comment in that PR).
tarcieri
added a commit
that referenced
this pull request
Feb 25, 2024
Replaces the existing ad hoc array size selections with the following, which cover all current known use cases: - 0-256 - 272-1024 (multiples of 16) - 1040-4096 (multiples of 32) This also effectively reverts #50, since it was adding considerably to compile times (now noted as a comment in that PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$leninput to the macro from the$tyinputU1408to the list of supported array sizes