Skip to content

Further expand array sizes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Further expand array sizes #52

merged 1 commit into from
Feb 25, 2024

Conversation

tarcieri
Copy link
Member

Replaces the existing ad hoc array size selections with the following, which cover all current known use cases:

  • 0-256
  • 272-1024 (multiples of 16)
  • 1040-4096 (multiples of 32)

This also effectively reverts #50, since it was adding considerably to compile times (now noted as a comment in that PR).

Replaces the existing ad hoc array size selections with the following,
which cover all current known use cases:

- 0-256
- 272-1024 (multiples of 16)
- 1040-4096 (multiples of 32)

This also effectively reverts #50, since it was adding considerably to
compile times (now noted as a comment in that PR).
@tarcieri
Copy link
Member Author

tarcieri commented Feb 25, 2024

This actually appears to improve compile-time performance over master by virtue of reverting #50, which it seems may have been accidentally quadratic by way of associated constant resolution

@tarcieri tarcieri merged commit 5adb57d into master Feb 25, 2024
@tarcieri tarcieri deleted the further-expand-array-sizes branch February 25, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant