Skip to content

[Fix] Slack repeats pull request status after session closeout #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[Fix] Slack repeats pull request status after session closeout #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1caf84a
fix: suppress session PR Slack status posts
mrubens Aug 29, 2026
04724ec
fix: classify Slack targets from latest task runs
mrubens Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 106 additions & 55 deletions apps/api/src/handlers/github/__tests__/notifyPullRequestTerminalStatus.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 23 additions & 2 deletions apps/api/src/handlers/github/notifyPullRequestTerminalStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
taskPullRequests,
taskRuns,
tasks,
desc,
eq,
and,
inArray,
Expand Down Expand Up @@ -825,6 +826,7 @@ export async function notifyPullRequestTerminalStatus({
}),
db.query.taskRuns.findMany({
where: inArray(taskRuns.taskId, taskIds),
orderBy: [desc(taskRuns.createdAt)],
columns: {
taskId: true,
payload: true,
Expand All @@ -834,9 +836,27 @@ export async function notifyPullRequestTerminalStatus({

const slackTargets: SlackTarget[] = [];
const linearSessionIds: string[] = [];
const latestRunsByTaskId = new Map<string, (typeof linkedRuns)[number]>();
for (const run of linkedRuns) {
if (!latestRunsByTaskId.has(run.taskId)) {
latestRunsByTaskId.set(run.taskId, run);
}
}
// Fast/session-backed tasks receive terminal PR events through their parent
// session. Keep this webhook fan-out only for legacy/direct Slack tasks so
// it cannot add a second canned status post to the same conversation.
const fastTaskIds = new Set(
[...latestRunsByTaskId.values()]
.filter((run) => getFastAgentParentFromPayload(run.payload) !== null)
Comment thread
roomote-roomote[bot] marked this conversation as resolved.
.map((run) => run.taskId),
);

for (const task of linkedTasks) {
if (task.slackThreadTs && task.slackChannelId) {
if (
!fastTaskIds.has(task.id) &&
task.slackThreadTs &&
task.slackChannelId
) {
slackTargets.push({
taskId: task.id,
slackThreadTs: task.slackThreadTs,
Expand All @@ -850,7 +870,8 @@ export async function notifyPullRequestTerminalStatus({
}

slackTargets.push(
...linkedRuns
...[...latestRunsByTaskId.values()]
.filter((run) => !fastTaskIds.has(run.taskId))
.map((run) => getSlackTarget(run.taskId, run.payload))
.filter((target): target is SlackTarget => target !== null),
);
Expand Down
Loading