[Fix] Slack repeats pull request status after session closeout - #1816
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Slack repeats pull request status after session closeout#1816roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Contributor
Author
|
Fixed the outstanding review issue in 04724ec1: Slack classification and run-derived delivery now use each task's latest run, with mixed Fast/direct history coverage. The review thread is resolved, and the follow-up Roomote review found no code issues. The escaped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fast/session-backed tasks are no longer included in the generic Slack pull-request terminal notification fan-out. Their parent session remains responsible for the terminal closeout and reaction, while direct and legacy Slack tasks keep the existing standalone status delivery.
Task classification and run-derived Slack delivery use each task's latest run, matching the existing Fast terminal-event path. Focused tests cover current session-backed and legacy tasks whose histories contain the opposite run type.
Why this change was made
The generic webhook path treated inherited Fast child Slack coordinates as direct notification destinations. That posted a canned pull-request status after the parent session had already received the same lifecycle event.
Impact
Slack conversations currently backed by Fast sessions no longer receive redundant standalone messages such as a pull request being merged or closed. Tasks whose latest run is direct or legacy continue to receive their existing status post and terminal reactions, even after an older Fast run.