Skip to content

Optimized the i18n model lookup. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Optimized the i18n model lookup. #214

merged 1 commit into from
Jan 22, 2021

Conversation

awhitford
Copy link
Contributor

  • Revised _i18nModel to use LocaleType as a key instead of String, and then revised i18nObjInLocale to do a simple lookup instead of a costly switch statement.
  • Added i18nObjInLocaleLookup convenience method.
  • Note that some code reformatted because Format on Save enabled.
  • Replaces PR Optimized the i18n model lookup. #209.

@awhitford awhitford mentioned this pull request Jan 16, 2021
Closed
@Realank Realank merged commit 1d52eb8 into Realank:master Jan 22, 2021
@awhitford awhitford deleted the i18n_model_2 branch January 22, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awhitford @Realank