Optimized the i18n model lookup. #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the selection of the right list is changed, the left and middle list is now refreshing the UI state.
…ter use InheritedTheme.captureAll (flutter/flutter#69050)
static ThemeData of BuildContext doesn't contain named parameter shadowThemeOnly:tre. From the latest version of Flutter we gets the error:
Error: No named parameter with the name 'shadowThemeOnly'.
ThemeData inheritTheme = Theme.of(context, shadowThemeOnly: true);
Fix spelling mistakes on Catalan language
add suport for khmer localization
Enabling UI refresh on change the right list
Use the localized am and pm strings in Time12hPickerModel
Remove parameter `shadowThemeOnly` from ThemeData
Realank#197 shadowThemeOnly is removed on flutter master
Added super(key) to _DatePickerComponent.
Realank
reviewed
Jan 15, 2021
|
I replaced this PR with PR #214 to capture the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_i18nModelto useLocaleTypeas a key instead ofString, and then revisedi18nObjInLocaleto do a simple lookup instead of a costly switch statement.i18nObjInLocaleLookupconvenience method.