Realank#197 shadowThemeOnly is removed on flutter master #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter use InheritedTheme.captureAll (flutter/flutter#69050)
|
Great work, I tried your patch, works perfect for me. |
|
Please merge soon if possible :D |
|
@Realank Could you please merge this? It is still not fixed. |
|
Can you please merge? |
|
@Realank You can also merge this one? |
lukee1234
approved these changes
Dec 11, 2020
Closed
|
Great fix @espresso3389. ありがとうございます @Realank Please merge or let us help you maintain the repository :) |
nstrelow
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #197;
flutter/flutter#69050 recently removed Theme.of(context, shadowThemeOnly) and it recommends to use
InheritedTheme.capturefor applying shadowing-themes to widgets. AlthoughInheritedTheme.captureis not available on stable/beta channel, we can still useInheritedTheme.captureAllfor the purpose.