Remove parameter shadowThemeOnly from ThemeData
#202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static ThemeData of BuildContext doesn't contain named parameter shadowThemeOnly:tre. From the latest version of Flutter we gets the error:
Error: No named parameter with the name 'shadowThemeOnly'.
ThemeData inheritTheme = Theme.of(context, shadowThemeOnly: true);
lukee1234
approved these changes
Dec 1, 2020
|
Please merge this. Or do you need help with maintaining this package @Realank ? |
|
This should resolve #206 |
|
Duplicates #197 |
|
And duplicates #199. 😕 |
harsimranmaan
approved these changes
Dec 16, 2020
|
Just merge please |
|
The changes in the PR is not correct (it breaks the consistency of the code) because it loses the original concept of extracting just shadowing theme differentials; I have another PR #199 and it keeps the concept of the original code. |
|
yes, I've merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static ThemeData of BuildContext doesn't contain named parameter shadowThemeOnly:tre. From the latest version of Flutter we gets the error:
Error: No named parameter with the name 'shadowThemeOnly'.
ThemeData inheritTheme = Theme.of(context, shadowThemeOnly: true);