Feat/multi qps per endpoint #318
Open
+204
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ROCSHMEM_GDA_NUM_QPS_PER_PE_DEFAULT_CTX` to control the number of QPs per PE in the default context. - `ROCSHMEM_GDA_NUM_QPS_PER_PE_USR_CTX` to control the number of QPs per PE in each user context.
- Added per-context QP allocation logic using environment variables - Added `get_qp_index(int pe)` to compute QP index using atomic counter for round-robin access.
…d update RMA/atomic APIs - Replaced per-thread atomic fetch with warp-synchronous logic using `__match_any_sync` and `__shfl_sync` to group threads targeting the same PE. - Only the leader lane performs the atomic increment, reducing contention. - Broadcasts the computed QP index to all participating lanes for efficiency. - Updated RMA and atomic APIs to use the new warp-synchronized QP indexing.
avinashkethineedi
requested review from
BKP,
Yiltan,
abouteiller,
akolliasAMD,
edgargabriel,
gaoikawa and
omor1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Environment Variables
ROCSHMEM_GDA_NUM_QPS_PER_PE_DEFAULT_CTX: Number of QPs per PE in the default context.ROCSHMEM_GDA_NUM_QPS_PER_PE_USR_CTX: Number of QPs per PE in each user context.get_qp_index()device method to compute QP index using atomic counterfor round-robin access.
Test Plan
Test Result
Submission Checklist