[GDA] Alltoall optimization - single warp #319
+237
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the collective is templated, we are just testing if sizeof(T) works
Yiltan
requested review from
BKP,
abouteiller,
akolliasAMD,
avinashkethineedi,
edgargabriel,
gaoikawa and
omor1
as code owners
nusislam
reviewed
Nov 13, 2025
| const T *src, int nelems) { | ||
| alltoall_linear_thread_puts(team, dst, src, nelems); | ||
| if (gda_provider_ == GDAProvider::BNXT) { | ||
| alltoall_linear_thread_puts(team, dst, src, nelems); |
There was a problem hiding this comment.
Why is this not applicable for other NICs?
Collaborator
Author
There was a problem hiding this comment.
- Should work on IONIC (untested, so I've left it out)
- There is a pretty major PR in the works for CX7, adding the logic to support multiple threads writing into their own QP would create a major conflict for them. It would be best to add this support once the other PR is merged
gaoikawa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Conflicts with #318, the two PRs need to be merged in some order