-
Notifications
You must be signed in to change notification settings - Fork 163
Fix outdated links #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beckykd
wants to merge
10
commits into
main
Choose a base branch
from
bd-update-external-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−7
Open
Fix outdated links #4506
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
04a7743
Fix outdated links
beckykd 144f166
Merge branch 'main' into bd-update-external-links
beckykd 72f20c6
Update scripts/js/lib/links/ignores.ts
beckykd d6945e1
remove the links that were fixed
beckykd 0e56e46
Merge branch 'main' into bd-update-external-links
beckykd 15cd726
add redirects
beckykd 732ca77
Add one more link to ignore
beckykd dbf78c3
It's being ignored; not redirected
beckykd 76a3849
remove from redirects because its in Ignore
beckykd 494f37d
don't need this
beckykd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,16 +163,16 @@ const ALWAYS_IGNORED_URLS__EXPECTED = [ | |
|
|
||
| // These external URLs cause actual 404s and should probably be fixed. | ||
| const ALWAYS_IGNORED_URLS__SHOULD_FIX: string[] = [ | ||
| // These schemas are not available any more. They might have moved, but we're not sure where. | ||
| // These schemas are not available any more. References to these in the new API docs have been fixed, | ||
| // but they will never be fixed in the old API docs. We decided to leave these links as-is for archival purposes. | ||
| "https://github.com/Qiskit/ibm-quantum-schemas/blob/main/schemas/backend_status_schema.json", | ||
| "https://github.com/Qiskit/ibm-quantum-schemas/blob/main/schemas/default_pulse_configuration_schema.json", | ||
| "https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-authenticate-with-ibm-credentials", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this link to be ignored now? I think we can remove it if it only appears in the qiskit-ibm-runtime release notes |
||
|
|
||
| // These links are from old IQP and do not work any more | ||
| "https://api.quantum-computing.ibm.com/runtime", | ||
| "https://auth.quantum-computing.ibm.com/api", | ||
| "https://auth.quantum.ibm.com/api", | ||
| "https://quantum-computing.cloud.ibm.com", | ||
| "https://us-east.quantum-computing.cloud.ibm.com/", | ||
|
|
||
| // Other links that don't seem to exist any more | ||
| "https://www.cs.bham.ac.uk/~xin/papers/published_tec_sep00_constraint.pdf", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link needs to be fixed in the runtime repo (
mainbranch andstable/0.45):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jessie said to just ignore it, since it's in a really old release note. I'll add to the Ignore file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we can't ignore the issue because it's in the release notes. Our script regenerates the whole release note file with each version, so we would revert the change in the future if it's not fixed.
We can only ignore issues with historical versions if it's in a page different than the release notes :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion we should fix it on the runtime repo and remove the redirect in
external-redirects.tsgiven that it won't be necessary anymoreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK