-
Notifications
You must be signed in to change notification settings - Fork 163
Fix outdated links #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix outdated links #4506
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
frankharkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
For the links in the API docs, we'll need to add the redirects to scripts/config/external-redirects.ts, otherwise these changes will be discarded when we next regenerate the docs from source.
The format is:
"old":
"new",E.g.
documentation/scripts/config/external-redirects.ts
Lines 38 to 39 in 2140419
| "https://aip.scitation.org/doi/10.1063/1.5141835": | |
| "https://pubs.aip.org/aip/jcp/article/152/12/124107/953761/Quantum-orbital-optimized-unitary-coupled-cluster", |
Co-authored-by: Frank Harkins <[email protected]>
Even though the changes will be made in the API docs themselves? |
Yep: We store the original API docs HTML in Box and sometimes re-run the HTML -> markdown pipeline to fix bugs. When this happens, your fixes will be overwritten by the pipeline with the original links. The |
|
@frankharkins what should we do about links that are broken in historical API documents but don't exist in more recent documents? For example, qaiskit-ibm-runtime/0.40/qiskit-runtime-service links to https://auth.quantum.ibm.com/api. That API no longer exists and the link was just deleted from the later versions. |
arnaucasau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Becky!!
| * The `channel_strategy` parameter in `QiskitRuntimeService` has been removed. To continue using Q-CTRL in your workflow, please explore the following options: | ||
|
|
||
| > * If your organization has an existing IBM Quantum Premium Plan instance: migrate to the Q-CTRL Performance Management Function, found in the [Qiskit Functions Catalog](https://quantum.ibm.com/functions). | ||
| > * To continue using Qiskit Runtime with IBM Cloud: migrate to Q-CTRL Fire Opal, the same performance management product accessible directly through Q-CTRL. You can [connect your IBM Cloud API key and Qiskit Runtime CRN](https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-authenticate-with-ibm-credentials) to Fire Opal. ([1966](https://github.com/Qiskit/qiskit-ibm-runtime/pull/1966)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link needs to be fixed in the runtime repo (main branch and stable/0.45):
I think if a link has no replacement, it's OK for it to be broken in a historical version. These are archives after all and it might even be helpful for a user to know that the API isn't available any more. Maybe just update the comment to explain we're not going to fix them. |
I updated the comment in the Ignore.ts file to explain why we're leaving the links that don't have a replacement as-is in the old API docs. I also added the redirects listed to the external-redirects file. |
Related to #4336