Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a NullPointerException when displaying SUI message boxes #1574

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Fixed a NullPointerException when displaying SUI message boxes #1574

merged 3 commits into from
Jul 5, 2024

Commits on Jul 2, 2024

  1. Tests now invoke SWGPacket#encode and SWGPacket#decode, so we can rep… 

    …roduce the SUI window packet serialization problem
    @madsboddum
    madsboddum committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a4d9e25 View commit details
    Browse the repository at this point in the history

  2. Fixed a packet encoding problem with SUI message boxes, so that they … 

    …now display again

This fixes a NullPointerException, where suiScript is assumed to be not-null during SuiCreatePageMessage#encode
    @madsboddum
    madsboddum committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0f1fc9c View commit details
    Browse the repository at this point in the history

  3. Check if the buffer was read 100%, to improve confidence in packet de… 

    …coding logic
    @madsboddum
    madsboddum committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ea50f4c View commit details
    Browse the repository at this point in the history