Fixed a NullPointerException when displaying SUI message boxes #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Larson
reviewed
Jul 2, 2024
src/test/java/com/projectswg/holocore/test/resources/GenericPlayer.java
Outdated
Show resolved
Hide resolved
…roduce the SUI window packet serialization problem
…now display again This fixes a NullPointerException, where suiScript is assumed to be not-null during SuiCreatePageMessage#encode
madsboddum
force-pushed
the
fix/sui/npe-encoding
branch
from
1f48806
to
ea50f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568.
I was able to reproduce the problem with our existing automated tests by simply introducing packet encoding and decoding in this commit: b7139af
The result isn't used for anything, although I think that would be cool to add in later for tests that give even more confidence.
The actual fix is here: b7139af