clang-tidy fixes #13776
Open
clang-tidy fixes #13776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9377096475Details
💛 - Coveralls |
omoerbeek
requested changes
Feb 10, 2024
neheb
force-pushed
the
cl
branch
2 times, most recently
from
c99170b
to
2420f31
Compare
Removed. |
omoerbeek
reviewed
Feb 12, 2024
pdns/sdig.cc
Outdated
| @@ -422,7 +422,7 @@ try { | |||
| Socket sock(dest.sin4.sin_family, SOCK_STREAM); | |||
| sock.setNonBlocking(); | |||
| setTCPNoDelay(sock.getHandle()); // disable NAGLE, which does not play nicely with delayed ACKs | |||
| TCPIOHandler handler(subjectName, false, sock.releaseHandle(), timeout, std::move(tlsCtx)); | |||
| TCPIOHandler handler(subjectName, false, sock.releaseHandle(), timeout, tlsCtx); | |||
rgacogne
reviewed
Feb 12, 2024
pdns/pdnsutil.cc
Outdated
| sd.db->abortTransaction(); | ||
| cerr<<"Backend did not replace SOA record. Backend might not support this operation."<<endl; | ||
| return -1; | ||
| vector<DNSResourceRecord> rrs(rr); |
There was a problem hiding this comment.
Suggested change
| vector<DNSResourceRecord> rrs(rr); | |
| vector<DNSResourceRecord> rrs = {rr}; |
There was a problem hiding this comment.
The initial syntax is wrong, there is no constructor in the std::vector class that accepts a single element. Now if your question is why = {rr} and not ({rr}), I don't really have an opinion since performance is completely irrelevant here, so whatever compiles would work for me.
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
parameter is not passed by value but by reference. Treat it that way. Signed-off-by: Rosen Penev <[email protected]>
|
CI passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other stuff as well.