fix memory leak

parameter is not passed by value but by reference. Treat it that way. Signed-off-by: Rosen Penev <[email protected]>
PowerDNS · Jun 5, 2024 · e22cac1 · e22cac1
1 parent 96b48ed
commit e22cac1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
@@ -924,10 +924,11 @@ static int increaseSerial(const DNSName& zone, DNSSECKeeper &dk)
 
   sd.db->startTransaction(zone, -1);
 
-  if (!sd.db->replaceRRSet(sd.domain_id, zone, rr.qtype, {rr})) {
-   sd.db->abortTransaction();
-   cerr<<"Backend did not replace SOA record. Backend might not support this operation."<<endl;
-   return -1;
+  auto rrs = vector<DNSResourceRecord>{rr};
+  if (!sd.db->replaceRRSet(sd.domain_id, zone, rr.qtype, rrs)) {
+    sd.db->abortTransaction();
+    cerr << "Backend did not replace SOA record. Backend might not support this operation." << endl;
+    return -1;
   }
 
   if (sd.db->doesDNSSEC()) {