[codex] Clarify legacy TAXSIM umbrella vars#7898
Open
MaxGhenis wants to merge 6 commits intoPolicyEngine:mainfrom
Open
[codex] Clarify legacy TAXSIM umbrella vars#7898MaxGhenis wants to merge 6 commits intoPolicyEngine:mainfrom
MaxGhenis wants to merge 6 commits intoPolicyEngine:mainfrom
Conversation
MaxGhenis
force-pushed
the
codex/issue-7897-taxsim-state-taxable-income
branch
from
ea38d31 to
427e60e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7898 +/- ##
===========================================
+ Coverage 97.26% 100.00% +2.73%
===========================================
Files 5 8 +3
Lines 73 97 +24
Branches 2 0 -2
===========================================
+ Hits 71 97 +26
+ Misses 1 0 -1
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These are first-class PE-US variables, not deprecated: - Remove "(legacy compatibility umbrella)" from all labels - Remove deprecation documentation strings - Restore original descriptions (not "Legacy compatibility list") Add missing states: - state_taxable_incomes: NH, PA - state_cdccs: WV, MD (refundable) - state_ctcs: NC - state_property_tax_credits: IL, MT (rebate), OK Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace triple-duplicated _ok_child_credit_components helper with delegation pattern (like MN): - ok_child_tax_credit_component: checks if CTC > CDCC, returns combined credit if so, else 0 - ok_child_care_credit_component: combined minus CTC component - ok_child_care_child_tax_credit: restored to original formula (max of CDCC and CTC portions, prorated) Components still sum to combined credit (verified). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This marks the remaining TAXSIM-shaped PE-US umbrella variables as legacy compatibility surfaces rather than generic cross-state PolicyEngine-US outputs.
What changed
state_taxable_income,state_agi,state_property_tax_credit,state_cdcc,state_eitc, andstate_ctcas legacy compatibility umbrellasWhy
Issue #7897 exposed that some TAXSIM outputs were relying on umbrella variables whose semantics are not internally consistent across states. This PR narrows PE-US responsibility to the aggregators that are truly core PE-US concepts, while the paired TAXSIM PR owns the explicit compatibility mapping layer.
Validation
uv run policyengine-core test /Users/maxghenis/worktrees/policyengine-us-issue-7897/policyengine_us/tests/policy/baseline/gov/tax/income/integration.yaml -c policyengine_usPaired PR