Skip to content

[Alt] Add TAXSIM compatibility variables in PE-US#7899

Closed
MaxGhenis wants to merge 1 commit intoPolicyEngine:mainfrom
MaxGhenis:codex/issue-7897-taxsim-compat-layer
Closed

[Alt] Add TAXSIM compatibility variables in PE-US#7899
MaxGhenis wants to merge 1 commit intoPolicyEngine:mainfrom
MaxGhenis:codex/issue-7897-taxsim-compat-layer

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • add namespaced taxsim_* compatibility variables in PE-US for ambiguous TAXSIM outputs
  • keep the migration surface in PE-US rather than encoding those semantics primarily in policyengine-taxsim
  • add focused tests for the compat layer and the OK/MN split-credit adapters

Notes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (edaf7b1) to head (bfc4436).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #7899      +/-   ##
===========================================
+ Coverage   97.26%   100.00%   +2.73%     
===========================================
  Files           5         3       -2     
  Lines          73       134      +61     
  Branches        2         1       -1     
===========================================
+ Hits           71       134      +63     
+ Misses          1         0       -1     
+ Partials        1         0       -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (+2.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxGhenis
Copy link
Copy Markdown
Contributor Author

Closing this alternative in favor of #7898, which matches the repo split we chose and is already green. Keeping the compat-layer approach here as a documented alternative if we revisit a migration-oriented PE-US compatibility surface later.

@MaxGhenis MaxGhenis closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant