Edit profile form (code clean up) #2312

sunilsabatp · 2024-11-20T10:01:30Z

Removed the address-related field and its logic from the edit profile.
Removed hardcode stylings.
use mixin for consistent layout styling.

…variables - Introduced SCSS mixins for reusable flexbox layouts and modal positioning. - Centralized common variables for padding, border-radius, and colors. - Simplified and modularized styles for better readability and maintainability. - Enhanced mobile responsiveness with improved `xsPhoneView` handling. - Optimized button and container styling for consistency across components.

vercel · 2024-11-20T10:01:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 7:54am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Nov 27, 2024 7:54am
planet-webapp-temp	⬜️ Ignored (Inspect)			Nov 27, 2024 7:54am

coderabbitai · 2024-11-20T10:01:37Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ean-up

mohitb35 · 2024-12-04T06:36:32Z

src/features/user/Settings/EditProfile/AddressManagment/AddressManagement.module.scss

+$border-radius-sm: 8px;
+$border-radius-lg: 16px;
+$padding-standard: 24px;


Personally, I feel these variables didn't need to be abstracted, and the code is harder to read with them.

Do we want to change padding-standard in one place and affect both SingleAddress and the address shown in the type update modals?

mohitb35 · 2024-12-04T06:40:39Z

Address conflicts

sunilsabatp added 3 commits November 20, 2024 11:26

refactor: clean up address related code in edit profile component

cb98e06

refactor: minor width adjustment.

ab12086

sunilsabatp requested a review from mohitb35 November 20, 2024 10:03

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 20, 2024 10:10 View deployment

mohitb35 added the PR: unreviewed label Nov 20, 2024

mariahosfeld added the addressmanagement label Nov 21, 2024

sunilsabatp mentioned this pull request Nov 21, 2024

Render list of addresses #2289

Merged

sunilsabatp added 2 commits November 27, 2024 10:56

Merge branch 'address-mgmt/address-actions' into address-mgmt/code-cl…

9d258ef

…ean-up

refactor(styles): use flex-container mixin for consistent layout styling

917756c

mariahosfeld mentioned this pull request Nov 27, 2024

BASE: Address Management #2286

Draft

1 task

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 27, 2024 07:54 View deployment

sunilsabatp changed the title ~~Address mgmt/code clean up~~ Edit profile form (code clean up) Nov 27, 2024

mohitb35 reviewed Dec 4, 2024

View reviewed changes

sunilsabatp mentioned this pull request Dec 4, 2024

Address actions #2308

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit profile form (code clean up) #2312

Edit profile form (code clean up) #2312

sunilsabatp commented Nov 20, 2024 •

edited

Loading

vercel bot commented Nov 20, 2024 •

edited

Loading

coderabbitai bot commented Nov 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mohitb35 Dec 4, 2024

mohitb35 commented Dec 4, 2024

Edit profile form (code clean up) #2312

Are you sure you want to change the base?

Edit profile form (code clean up) #2312

Conversation

sunilsabatp commented Nov 20, 2024 • edited Loading

vercel bot commented Nov 20, 2024 • edited Loading

coderabbitai bot commented Nov 20, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mohitb35 Dec 4, 2024

Choose a reason for hiding this comment

mohitb35 commented Dec 4, 2024

sunilsabatp commented Nov 20, 2024 •

edited

Loading

vercel bot commented Nov 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)