Address actions #2308

sunilsabatp · 2024-11-14T10:30:27Z

This PR handle the address actions (delete, setPrimary, setBilling).

- add delete functionality for address entries - move isUploadingData state to parent component - refactor child components to use shared loading state

vercel · 2024-11-14T10:30:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 4, 2024 9:50am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Dec 4, 2024 9:50am
planet-webapp-temp	⬜️ Ignored (Inspect)			Dec 4, 2024 9:50am

coderabbitai · 2024-11-14T10:41:06Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ne address form types - Refactored translation key to use ICU select pattern for dynamic translations. - use useMemo to find primary, billing, address - Defined constant ADDRESS_FORM_TYPE for address form actions (add, edit) and associated type.

…ze modal rendering with useMemo and useCallback"

… to the root component

…ss-actions

…n useCallback

…ss-actions

mariahosfeld

Functionality looks good to me.

…ss-actions

mohitb35

@sunilsabatp Mostly minor feedback, except for the state management of addressAction

mohitb35 · 2024-12-02T10:07:31Z

public/static/locales/en/profile.json

+      "deleteAddress": "Delete Address",
+      "delete": "Delete",
+      "addressConfirmationMessage": "Are you sure you want to set this address as your {addressType, select, mailing {billing} other {{addressType}}} address? {isAddressSet, select, true {This will replace your current {addressType, select, mailing {billing} other {{addressType}}} address.} other {}}",
+      "deleteAddressConfirmationMessage": "Are you sure you want to delete this address? If you want to use it again, please add it as a new address.",
+      "confirm": "Confirm",
+      "address2": "Address 2(optional)",


Do some of the keys that are currently outside need to be moved/grouped?

For example, I see delete, and address2 keys

I'll handle this in a separate PR.

public/static/locales/en/profile.json

src/features/user/Settings/EditProfile/AddressManagment/index.tsx

src/features/user/Settings/EditProfile/AddressManagment/AddressDeleteModal.tsx

mohitb35 · 2024-12-04T05:20:20Z

src/features/user/Settings/EditProfile/AddressManagment/AddressManagement.module.scss

Could you clean up this scss file? Spacing between classes is erratic

I'll cover in this #2312

- fetchUserAddresses -> updateUserAddresses - AddressDeleteModal -> DeleteAddress - AddressTypeConfirmationModal -> UpdateAddressType

…ction type

mohitb35

@sunilsabatp Made a couple of small changes. LGTM.

sunilsabatp added 4 commits November 13, 2024 17:45

feat: set address type modal UI

cfd513d

feat: modify the edit address api to handle change address type

26c7cd3

feat: component rename for better clarity

7a29a2b

feat: implement delete action & lift state management

dbdc164

- add delete functionality for address entries - move isUploadingData state to parent component - refactor child components to use shared loading state

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 14, 2024 10:35 View deployment

sunilsabatp added 2 commits November 16, 2024 12:58

refactor singleAddress component: simplify address formatting, optimi…

7ea7126

…ze modal rendering with useMemo and useCallback"

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 17, 2024 16:30 View deployment

mohitb35 added the PR: unreviewed label Nov 20, 2024

mariahosfeld added the addressmanagement label Nov 21, 2024

sunilsabatp mentioned this pull request Nov 21, 2024

Render list of addresses #2289

Merged

sunilsabatp added 8 commits November 22, 2024 20:14

merge: merge base branch, shift setAddressType(primary,billing) modal…

4be3b81

… to the root component

refactor: shift address delete modal to the root component

13311ac

refactor: simplify AddressTypeConfirmationModal component

b16d705

Merge branch 'address-mgmt/edit-address-form' into address-mgmt/addre…

4a5f0e4

…ss-actions

refactor: simplify address formatting logic,

aaa5848

feat: add FormattedAddressBlock component to display user address

df3db69

refactor: rename variable, and wrap the fetchUserAddresses function i…

ea0228b

…n useCallback

refactor: merge base branch, resolve conflicts

ccc8ce4

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 25, 2024 10:55 View deployment

Merge branch 'address-mgmt/edit-address-form' into address-mgmt/addre…

eb6896e

…ss-actions

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 26, 2024 10:18 View deployment

refactor: minor ui fixes

64f7351

sunilsabatp requested review from mohitb35 and mariahosfeld November 26, 2024 10:45

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 26, 2024 10:57 View deployment

mariahosfeld mentioned this pull request Nov 27, 2024

BASE: Address Management #2286

Merged

1 task

mariahosfeld reviewed Nov 27, 2024

View reviewed changes

sunilsabatp changed the title ~~Address mgmt/address actions~~ Address actions Nov 27, 2024

Merge branch 'address-mgmt/edit-address-form' into address-mgmt/addre…

6df7098

…ss-actions

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup November 29, 2024 07:06 View deployment

Merge branch 'address-mgmt/edit-address-form' into address-mgmt/addre…

f69fd7b

…ss-actions

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup December 2, 2024 09:03 View deployment

Base automatically changed from address-mgmt/edit-address-form to feature/address-mgmt December 2, 2024 09:04

sunilsabatp added 2 commits December 2, 2024 15:10

refactor: remove unneeded files

9ff8673

Merge branch 'feature/address-mgmt' into address-mgmt/address-actions

6523041

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup December 2, 2024 10:01 View deployment

mohitb35 requested changes Dec 4, 2024

View reviewed changes

mohitb35 added PR: reviewed-changes-requested and removed PR: unreviewed labels Dec 4, 2024

sunilsabatp added 5 commits December 4, 2024 11:43

refactor: rename component/function/props.

3837dc7

- fetchUserAddresses -> updateUserAddresses - AddressDeleteModal -> DeleteAddress - AddressTypeConfirmationModal -> UpdateAddressType

"refactor: reset addressAction state when the modal is opened or closed

6783400

refactor: minor code clean up

075a427

refactor: simplify translation interpolation

9e154b6

refactor: rename tProfile to tAddressManagement

ef5ce97

sunilsabatp requested a review from mohitb35 December 4, 2024 08:13

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup December 4, 2024 08:19 View deployment

mohitb35 added 2 commits December 4, 2024 15:06

refactor: update address confirmation messages for clarity and structure

035c34e

fix: corrects import path for ADDRESS_ACTIONS while creating AddressA…

b64c57f

…ction type

mohitb35 approved these changes Dec 4, 2024

View reviewed changes

mohitb35 added PR: reviewed-approved and removed PR: reviewed-changes-requested labels Dec 4, 2024

sunilsabatp merged commit 1525e50 into feature/address-mgmt Dec 4, 2024
4 of 5 checks passed

sunilsabatp deleted the address-mgmt/address-actions branch December 4, 2024 09:48

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup December 4, 2024 09:50 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address actions #2308

Address actions #2308

sunilsabatp commented Nov 14, 2024

vercel bot commented Nov 14, 2024 •

edited

Loading

coderabbitai bot commented Nov 14, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mariahosfeld left a comment

mohitb35 left a comment

mohitb35 Dec 2, 2024

sunilsabatp Dec 4, 2024

mohitb35 Dec 4, 2024

sunilsabatp Dec 4, 2024 •

edited

Loading

mohitb35 left a comment

Address actions #2308

Address actions #2308

Conversation

sunilsabatp commented Nov 14, 2024

vercel bot commented Nov 14, 2024 • edited Loading

coderabbitai bot commented Nov 14, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mariahosfeld left a comment

Choose a reason for hiding this comment

mohitb35 left a comment

Choose a reason for hiding this comment

mohitb35 Dec 2, 2024

Choose a reason for hiding this comment

sunilsabatp Dec 4, 2024

Choose a reason for hiding this comment

mohitb35 Dec 4, 2024

Choose a reason for hiding this comment

sunilsabatp Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

mohitb35 left a comment

Choose a reason for hiding this comment

vercel bot commented Nov 14, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

sunilsabatp Dec 4, 2024 •

edited

Loading