Updates contact form validation to match to backend #446

mohitb35 · 2023-11-09T10:48:18Z

Resolves errors faced due to mismatch in server/client validation for the contact form fields

Changes:

Updates validation rules in contact form fields
Removes redundant error displaying code and standardizes logic by using errors.{fieldname}.message
Updates error messages and styles to handle longer messages
Adds dependencies
a. hookform/devtools to debug rhf forms when needed
b. babel/plugin-transform-unicode-regex - to allow unicode regexp patterns as used in server validation

- hookform/devtools to debug the rhf forms - babel/plugin-transform-unicode-regex to enable unicode regexp

- updates contact form validation rules - updates error text - stores error messages in error.fieldname.message to reduce duplication - updates form-error styles to enable longer messages

- GiftForm.tsx - OnBehalf.tsx

vercel · 2023-11-09T10:48:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
donate-with-planet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2023 3:10pm

src/Donations/Components/ContactsForm.tsx

prachigarg19 · 2023-11-10T09:45:07Z

I was able to add just - as a valid value in first name and last name. Is this the expected behavior?

Same goes for company name, I'm able to add just a special character as a valid value.

src/Donations/Components/ContactsForm.tsx

mohitb35 · 2023-11-10T10:08:40Z

I was able to add just - as a valid value in first name and last name. Is this the expected behavior?

Same goes for company name, I'm able to add just a special character as a valid value.

Ideally should not be possible, but I'm trying to match the validation to the backend.

@jmiridis @mariahosfeld should we update this to prevent special characters at the start of the first name, last name, and company name?

mariahosfeld · 2023-11-10T12:41:13Z

I was able to add just - as a valid value in first name and last name. Is this the expected behavior?

Same goes for company name, I'm able to add just a special character as a valid value.

Ideally should not be possible, but I'm trying to match the validation to the backend.

@jmiridis @mariahosfeld should we update this to prevent special characters at the start of the first name, last name, and company name?

Even though it might be an edge case, I think for first name & last name we should prevent.

mariahosfeld · 2023-11-10T12:41:54Z

I was able to add just - as a valid value in first name and last name. Is this the expected behavior?

Same goes for company name, I'm able to add just a special character as a valid value.

For company name it is okay, we need to allow starting with a special character.

mariahosfeld

Tested functionality regarding communication as well as general behavior, everything works for me as expected.

- disallows entries beginning with special characters

mohitb35 · 2023-11-20T15:27:37Z

I was able to add just - as a valid value in first name and last name. Is this the expected behavior?

Same goes for company name, I'm able to add just a special character as a valid value.

For company name it is okay, we need to allow starting with a special character.

Resolved in 83413f1

prachigarg19 · 2023-11-22T07:01:55Z

lgtm

norbertschuler

Seems to work (commented possible clean ups)

norbertschuler · 2023-11-29T07:43:45Z

package.json

@@ -53,6 +53,8 @@
    "zod": "^3.22.4"
  },
  "devDependencies": {
+    "@babel/plugin-transform-unicode-regex": "^7.22.5",
+    "@hookform/devtools": "^4.3.1",


Is this still necessary after you commented the import in the code below?

not needed. but it makes it easier to debug react hook form when necessary.

norbertschuler · 2023-11-29T07:44:40Z

src/Donations/Components/ContactsForm.tsx

@@ -19,6 +19,7 @@ import { AddressCandidate, GeocodeSuggestion } from "src/Common/Types/arcgis";
 import GiftIcon from "public/assets/icons/GiftIcon";
 import { euCountries } from "src/Utils/countryUtils";
 import { isEmailValid } from "src/Utils/isEmailValid";
+// import { DevTool } from "@hookform/devtools";


Maybe just remove this line or do you want to keep it as some form of documentation on how to debug?

mariahosfeld

Lgtm

mohitb35 added 3 commits November 9, 2023 16:11

chore: installs dev dependencies

3a59d74

- hookform/devtools to debug the rhf forms - babel/plugin-transform-unicode-regex to enable unicode regexp

feat: matches contact form validation to backend

bbb9b28

- updates contact form validation rules - updates error text - stores error messages in error.fieldname.message to reduce duplication - updates form-error styles to enable longer messages

fix: resolves UX issues in "form-error" blocks

ab46edd

- GiftForm.tsx - OnBehalf.tsx

vercel bot deployed to Preview November 9, 2023 10:48 View deployment

github-advanced-security bot found potential problems Nov 9, 2023

View reviewed changes

src/Donations/Components/ContactsForm.tsx Fixed Show fixed Hide fixed

mohitb35 requested review from prachigarg19 and mariahosfeld November 9, 2023 10:51

fix: fixes overly permissive regexp range

560e971

vercel bot deployed to Preview November 9, 2023 11:02 View deployment

mohitb35 added the PR: unreviewed label Nov 9, 2023

prachigarg19 reviewed Nov 10, 2023

View reviewed changes

src/Donations/Components/ContactsForm.tsx Outdated Show resolved Hide resolved

fix: corrects error message for companyName

754e107

vercel bot deployed to Preview November 10, 2023 10:07 View deployment

mariahosfeld reviewed Nov 10, 2023

View reviewed changes

norbertschuler self-requested a review November 12, 2023 10:26

prachigarg19 mentioned this pull request Nov 15, 2023

Updates profile validation Plant-for-the-Planet-org/planet-webapp#1920

Merged

feat: updates contact form val. (first/last name)

83413f1

- disallows entries beginning with special characters

vercel bot deployed to Preview November 20, 2023 15:10 View deployment

mohitb35 requested review from mariahosfeld and prachigarg19 November 20, 2023 15:29

prachigarg19 approved these changes Nov 22, 2023

View reviewed changes

norbertschuler approved these changes Nov 29, 2023

View reviewed changes

mariahosfeld reviewed Nov 29, 2023

View reviewed changes

mariahosfeld merged commit 330e4de into develop Nov 29, 2023
5 checks passed

mariahosfeld deleted the feature/update-contact-form-validation branch November 29, 2023 09:45

mariahosfeld mentioned this pull request Nov 29, 2023

Release December #443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates contact form validation to match to backend #446

Updates contact form validation to match to backend #446

mohitb35 commented Nov 9, 2023 •

edited

Loading

vercel bot commented Nov 9, 2023 •

edited

Loading

prachigarg19 commented Nov 10, 2023 •

edited

Loading

mohitb35 commented Nov 10, 2023

mariahosfeld commented Nov 10, 2023

mariahosfeld commented Nov 10, 2023

mariahosfeld left a comment

mohitb35 commented Nov 20, 2023

prachigarg19 commented Nov 22, 2023

norbertschuler left a comment

norbertschuler Nov 29, 2023

mohitb35 Dec 11, 2023

norbertschuler Nov 29, 2023

mariahosfeld left a comment

Updates contact form validation to match to backend #446

Updates contact form validation to match to backend #446

Conversation

mohitb35 commented Nov 9, 2023 • edited Loading

vercel bot commented Nov 9, 2023 • edited Loading

prachigarg19 commented Nov 10, 2023 • edited Loading

mohitb35 commented Nov 10, 2023

mariahosfeld commented Nov 10, 2023

mariahosfeld commented Nov 10, 2023

mariahosfeld left a comment

Choose a reason for hiding this comment

mohitb35 commented Nov 20, 2023

prachigarg19 commented Nov 22, 2023

norbertschuler left a comment

Choose a reason for hiding this comment

norbertschuler Nov 29, 2023

Choose a reason for hiding this comment

mohitb35 Dec 11, 2023

Choose a reason for hiding this comment

norbertschuler Nov 29, 2023

Choose a reason for hiding this comment

mariahosfeld left a comment

Choose a reason for hiding this comment

mohitb35 commented Nov 9, 2023 •

edited

Loading

vercel bot commented Nov 9, 2023 •

edited

Loading

prachigarg19 commented Nov 10, 2023 •

edited

Loading