-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release December #443
Merged
Merged
Release December #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- marks `unit` as deprecated - updates to `unitType` throughout code
- only for tree/conservation projects
- this is seen in the Left Panel - Also converts `getAdditionalInfo` into a pure function - Also adds a separate type definition for UnitType
* PC = PlanetCash
…twitter-icon Replace twitter icon
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…rom-main Merge from main
1. add common function for email validation 2. add INVALID_DOMAIN_LIST check
1. remove unused import 2. combine and update error messages
…alidation Feature/email validation
- updates planet-sdk to get latest `Donation` type - adapts thank you message and image text for donations with unitType = m2 and purpose = trees
- disables inv. gifts for "trees+m2" donations - enables PC payment only for "unitType: tree" donations
- hookform/devtools to debug the rhf forms - babel/plugin-transform-unicode-regex to enable unicode regexp
- updates contact form validation rules - updates error text - stores error messages in error.fieldname.message to reduce duplication - updates form-error styles to enable longer messages
- GiftForm.tsx - OnBehalf.tsx
- disallows entries beginning with special characters
Project Name: Planet Donations Project Link: https://translate.lingohub.com/plant-for-the-planet/dashboard/planet-donations User: Norbert Schuler Easy language translations with LingoHub 🚀
…ge_update_2023-11-26Z Language update from LingoHub 🤖 on 2023-11-26Z
…contact-form-validation Updates contact form validation to match to backend
Project Name: Planet Donations Project Link: https://translate.lingohub.com/plant-for-the-planet/dashboard/planet-donations User: Maria Hosfeld Easy language translations with LingoHub 🚀
…ge_update_2023-11-29Z Language update from LingoHub 🤖 on 2023-11-29Z
…te-unit-type Integrate `unitType`
Project Name: Planet Donations Project Link: https://translate.lingohub.com/plant-for-the-planet/dashboard/planet-donations User: Maria Hosfeld Easy language translations with LingoHub 🚀
…ge_update_2023-11-29Z Language update from LingoHub 🤖 on 2023-11-29Z
mariahosfeld
requested review from
mohitb35
and removed request for
Shreyaschorge
December 8, 2023 13:42
mohitb35
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariahosfeld LGTM after updating planet-sdk version (#452)
…planet-sdk Updates planet sdk
mohitb35
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
unitType
#424