Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] ensure we respect PXR_WORK_THREAD_LIMIT (standalone) #3370

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Oct 21, 2024

Important

This is a duplicate of this PR:

...except pulled out of the UsdLux-HdEmbree PR "chain", to make for easier standalone integration, as it has no other PR dependencies, and is a simple/small change.

I will close this PR if the other is merged first, and vice-versa.

Description of Change(s)

Fixes an issue where pre-oneTBB, threads spawned from the non-root thread (such as the render thread) would not respect PXR_WORK_THREAD_LIMIT

Fixes Issue(s)

  • renderThread-spawned processes don't respect PXR_WORK_THREAD_LIMIT
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10340

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmolodo pmolodo force-pushed the pr/hdEmbree-respect-PXR_WORK_THREAD_LIMIT-standalone branch from 57a4e85 to 5a818ce Compare October 22, 2024 18:13
@pmolodo pmolodo force-pushed the pr/hdEmbree-respect-PXR_WORK_THREAD_LIMIT-standalone branch from 5a818ce to 32d1f06 Compare October 23, 2024 18:19
@pmolodo
Copy link
Contributor Author

pmolodo commented Oct 23, 2024

Updated to not modify the API of the work library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants