Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work: move work thread limit within namespace #3280

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rpoyner-tri
Copy link

Description of Change(s)

Puts the PXR_WORK_THREAD_LIMIT symbol within the PXR_NAMESPACE.

Other TF_DEFINE_ENV_SETTING() invocations are within the namespace; this is the only one I've found that is not.

Fixes Issue(s)

Partial fix for #3279.

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10095

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nvmkuruc
Copy link
Collaborator

This seems like simple and helpful fix.

@pmolodo FYI-- if this gets accepted, it may affect #3370

@nvmkuruc nvmkuruc added the build Build-related issue/PR label Oct 23, 2024
@pmolodo
Copy link
Contributor

pmolodo commented Oct 24, 2024

This seems like simple and helpful fix.

@pmolodo FYI-- if this gets accepted, it may affect #3370

Actually, released some changes to #3370 so that it won't be affected - PXR_WORK_THREAD_LIMIT isn't exported as part of the interface, so I had to retrieve the env var by name (via Tf_GetEnvSettingByName, which despite the Tf_ prefix, is exported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants