Step 0 does not affect the end result #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is helpful to point out that these steps do not make changes to their babs project. I pointlessly got into the habit of doing this every time.
|
Oh no sorry about that. Sounds good! Let me know if you think it's done here / it's ready to be merged? If so, I'll merge it into main. Thanks! |
|
@zhao-cy thanks, I think it's good to go! |
|
Hey @asmacdo ! Thanks a lot! Sorry for waiting for a long time.. There was an error in circle ci when merging but I reran circle ci (pytest part) and it passes now. I guess there were some temporary issues (e.g., connection to OSF?) that caused the error. I'm graduating and leaving the lab in the next several days. If you have any new PRs, please ask in the BABS slack channel to see who will be the best person to review. Thanks a lot for all of you've done!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is helpful to point out that these steps do not make changes to their babs project. I pointlessly got into the habit of doing this every time.