-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for NonGeoDatasets #433
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## beta #433 +/- ##
==========================================
- Coverage 98.43% 97.77% -0.66%
==========================================
Files 32 39 +7
Lines 3631 4143 +512
==========================================
+ Hits 3574 4051 +477
- Misses 57 92 +35 ☔ View full report in Codecov by Sentry. |
This major PR adds experimental support for
NonGeoDatasets
tominerva
.Warning
This new functionality is still somewhat experimental. Effort has been made to eliminate bugs and replicate the same functionality of
GeoDataset
withNonGeoDataset
but there are some gaps.Updates
torchgeo.datasets.NonGeoDataset
#426PairedDataset
intoPairedGeoDataset
andPairedNonGeoDataset
SSL4EOS12Sentinel2
intoGeoSSL4EOS12Sentinel2
andNonGeoSSL4EOS12Sentinel2
PairedConcatDataset
. Replicates the functions ofPairedUnionDataset
but forNonGeoDataset
.MinervaNonGeoDataset
. Extension ofNonGeoDataset
that adds a__or__
method so that thedataset1 | dataset2
syntax still works.MultiSpectralDataset
. Generic dataset for multi-spectral imagery using bothNonGeoDataset
andVisionDataset
.factory.py
to supportNonGeoDataset
example_GeoSimConvNet.yml
now usesNonGeoSSL4EOS12Sentinel2
(and associated changes)Note
From a user perspective, there are no breaking changes. As long as you are using
minerva
via theYAML
or CLI, no changes are needed.Major contributions from @jonhare