Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support torchgeo.datasets.NonGeoDataset #426

Open
Pale-Blue-Dot-97 opened this issue Jan 29, 2024 · 0 comments · Fixed by #433
Open

Support torchgeo.datasets.NonGeoDataset #426

Pale-Blue-Dot-97 opened this issue Jan 29, 2024 · 0 comments · Fixed by #433
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Pale-Blue-Dot-97
Copy link
Owner

Is your feature request related to a problem? Please describe.
Not all datasets in torchgeo are GeoDatasets -- some are NonGeoDatasets that do not use geospatial information. I am having issues with CRSs when using a global, pre-patched dataset like SSL4EO-S12. torchgeo already supports this dataset with a torchgeo.datasets.SSL4EO-S12 but is a NonGeoDataset. However, a lot of minerva is designed to work with GeoDataset, particularly the paired sampling.

Describe the solution you'd like
Generalise minerva to work with NonGeoDataset. In particular, there will need to be versions of PairedDataset and PairedUnionDataset that work with NonGeoDataset and the associated paired sampling.

Describe alternatives you've considered
The issue encountered with the CRS in SSL4EO-S12 relates to the projection system resulting in patches sampled with missing data. This could alternatively be avoided by rejecting any samples containing zeros -- but this would be an inefficient and messy implementation.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added bug Something isn't working enhancement New feature or request labels Jan 29, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 self-assigned this Jan 29, 2024
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 linked a pull request Feb 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant