Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 온보딩 UI #219

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[FIX] 온보딩 UI #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c9400a
[CHORE] Onboarding LottieImageView's Constraints
WhiteHyun Mar 16, 2023
53095b0
[CHORE] Onboarding Lottie json files
WhiteHyun Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PLUB/Configuration/Lottie/Onboarding/Onboarding1.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion PLUB/Configuration/Lottie/Onboarding/Onboarding2.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion PLUB/Sources/Views/Onboarding/OnboardingViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ final class OnboardingViewController: BaseViewController {
override func setupConstraints() {
super.setupConstraints()
onboardingView.snp.makeConstraints {
$0.size.equalTo(240)
$0.directionalHorizontalEdges.equalToSuperview().inset(16)
$0.height.equalTo(onboardingView.snp.width).dividedBy(1.36)
$0.centerX.equalToSuperview()
$0.centerY.equalToSuperview().dividedBy(1.564)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapkit 내부에 dividedBy 이런게 있었군요 꿀정보 감사합니다~!👍👍

}
Expand Down