[FIX] 온보딩 UI #219
Merged
[FIX] 온보딩 UI #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
디자인 파트에서 UI수정이 이루어졌고 그에 맞게 적용 특히 Lottie Image는 정적 사이즈가 아니라 width에 맞게 height를 비율로 설정하여 모든 아이폰에 같은 비율의 Image가 보이도록 설정
WhiteHyun
added
🍎 ConfigureUI
soobin-k
approved these changes
Mar 16, 2023
| @@ -51,7 +51,8 @@ final class OnboardingViewController: BaseViewController { | |||
| override func setupConstraints() { | |||
| super.setupConstraints() | |||
| onboardingView.snp.makeConstraints { | |||
| $0.size.equalTo(240) | |||
| $0.directionalHorizontalEdges.equalToSuperview().inset(16) | |||
| $0.height.equalTo(onboardingView.snp.width).dividedBy(1.36) | |||
| $0.centerX.equalToSuperview() | |||
| $0.centerY.equalToSuperview().dividedBy(1.564) | |||
There was a problem hiding this comment.
snapkit 내부에 dividedBy 이런게 있었군요 꿀정보 감사합니다~!👍👍
dlrjswns
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈