-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement petab.*
deprecation with __getattr__
#297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. It will break any isinstance(petab.v1.Problem(...), petab.Problem)
not sure if that's a real concern?!
That we be a problem a not-updated module checks inputs from an updated module.
petab.Problem
in favor of petab.v1.Problem
petab.*
deprecation with __getattr__
Should |
I am undecided what we should import there. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
+ Coverage 74.02% 74.49% +0.47%
===========================================
Files 73 46 -27
Lines 4800 4729 -71
Branches 1029 1034 +5
===========================================
- Hits 3553 3523 -30
+ Misses 953 908 -45
- Partials 294 298 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks. Let's get rid of that asap 🙈
Fixes an issue introduced in PEtab-dev#297, which made all optional dependencies required.
Fixes an issue introduced in #297, which made all optional dependencies required.
No description provided.