Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement petab.* deprecation with __getattr__ #297

Merged
merged 17 commits into from
Jul 1, 2024
Merged

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jul 1, 2024

No description provided.

@dilpath dilpath requested a review from a team as a code owner July 1, 2024 14:40
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. It will break any isinstance(petab.v1.Problem(...), petab.Problem) not sure if that's a real concern?!
That we be a problem a not-updated module checks inputs from an updated module.

petab/v1/problem.py Outdated Show resolved Hide resolved
@dilpath dilpath changed the title Deprecation warning for petab.Problem in favor of petab.v1.Problem Implement petab.* deprecation with __getattr__ Jul 1, 2024
@dilpath dilpath requested a review from dweindl July 1, 2024 15:54
@dilpath
Copy link
Member Author

dilpath commented Jul 1, 2024

Should from .versions import * be in petab/__init__.py?

@dilpath dilpath requested a review from m-philipps as a code owner July 1, 2024 16:13
@dweindl
Copy link
Member

dweindl commented Jul 1, 2024

Should from .versions import * be in petab/__init__.py?

I am undecided what we should import there.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (96d16fc) to head (fe7bf19).

Files Patch % Lines
petab/__init__.py 78.78% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
+ Coverage    74.02%   74.49%   +0.47%     
===========================================
  Files           73       46      -27     
  Lines         4800     4729      -71     
  Branches      1029     1034       +5     
===========================================
- Hits          3553     3523      -30     
+ Misses         953      908      -45     
- Partials       294      298       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Let's get rid of that asap 🙈

@dilpath dilpath merged commit c9074f7 into develop Jul 1, 2024
13 checks passed
@dilpath dilpath deleted the deprecate_problem branch July 1, 2024 21:02
dweindl added a commit to dweindl/libpetab-python that referenced this pull request Jul 2, 2024
Fixes an issue introduced in PEtab-dev#297, which made all optional dependencies required.
@dweindl dweindl mentioned this pull request Jul 2, 2024
dweindl added a commit that referenced this pull request Jul 2, 2024
Fixes an issue introduced in #297, which made all optional dependencies required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants