Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports #298

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix imports #298

merged 1 commit into from
Jul 2, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 2, 2024

Fixes an issue introduced in #297, which made all optional dependencies required.

Fixes an issue introduced in PEtab-dev#297, which made all optional dependencies required.
@dweindl dweindl requested a review from dilpath July 2, 2024 07:25
@dweindl dweindl requested a review from a team as a code owner July 2, 2024 07:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (c9074f7) to head (9447f78).

Files Patch % Lines
petab/__init__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
- Coverage    74.49%   74.47%   -0.03%     
===========================================
  Files           46       46              
  Lines         4729     4732       +3     
  Branches      1034     1034              
===========================================
+ Hits          3523     3524       +1     
- Misses         908      910       +2     
  Partials       298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dweindl dweindl merged commit e4b1861 into PEtab-dev:develop Jul 2, 2024
7 checks passed
@dweindl dweindl deleted the fix_import branch July 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants