-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using observable IDs in observableFormula
and noiseFormula
#562
Conversation
Following up on #543 and the discussion during the last PEtab editor meeting: There was general consent to allow using observableIDs in the `noiseFormula` column in the observables table. What was not discussed explicitly: * Should all observable IDs be allowed, or only the current one? * If so, should it be allowed to use observable IDs inside `observableFormula`? CC @PEtab-dev/petab-editors Closes ##543
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good to me. Thanks!
As to
I'm fine with allowing all.
I don't see a problem with that, as long as this introduces no circularity, which you addressed in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Could change the example to be
noiseParameter1_observable_pErk + noiseParameter2_observable_pErk*observable_pErk
instead of
noiseParameter1_observable_pErk + noiseParameter2_observable_pErk*pErk
Should all observable IDs be allowed, or only the current one?
Fine for me to allow all observable IDs.
If so, should it be allowed to use observable IDs inside
observableFormula
?
Fine for me to allow all observable IDs inside observableFormula
.
Following up on #543 and the discussion during the last PEtab editor meeting: There was general consent to allow using observableIDs in the
noiseFormula
column in the observables table.What was not discussed explicitly:
observableFormula
?CC @PEtab-dev/petab-editors
Closes #543