Java update from 21.0.4 to 21.0.5 including different depenndencies #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded CheckStyle from 10.18.1 to 10.20.1 Upgraded pmd from 7.6.0 to 7.7.0 Corrected pmd error in ClassLevelTableModel.java
Updated ruleset.xml, renamed deprecated rules.
Signed-off-by: Vest <[email protected]>
|
@Vest - I can Squash and merge but not pure merge (unless I override at the org). LMK what you prefer. |
karianna
requested changes
Nov 11, 2024
|
I prefer squash, because I don’t like scattered commits. People can always find how I came to this commit, if they read this PR. |
Removed two semicolons. Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
karianna
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karianna, I have prepared this PR with a small update. Can you please review it?
Please merge the changes, and don't rebase them.
p.s. I made a typo in one of the commit messages, I have updated Java to 21.0.5, and not to 21.0.4.