Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE-3531: increased the number of recent files from 8 to 20 #7222

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

Vest
Copy link
Contributor

@Vest Vest commented Nov 11, 2024

This feature is incomplete, because it is not configurable.
I have created it, because one of users from Discord asked a longer list.

Here are other changes:
Massive refactoring of PropertyContext.java and switching to Java's Optional and Streams if possible. Slightly reduced the dependency to Apache Commons.
Resolved many warnings suggested by IDEA and SonarLint.

@karianna
Please merge this PR (if you accept it), after you merge PR #7221, because you will likely get errors from PMD.

…is not configurable

Massive refactoring of PropertyContext.java and switching to Java's Optional and Streams if possible.
Slightly reduced the dependency to ApacheCommons.
Resolved many warnings suggested by IDEA and SonarLint.

Signed-off-by: Vest <[email protected]>
@Vest
Copy link
Contributor Author

Vest commented Nov 11, 2024

Just in case, link to the story: https://pcgenorg.atlassian.net/browse/CODE-3531

Added two @param descriptions (for IDEA).

Signed-off-by: Vest <[email protected]>
@Vest Vest requested a review from karianna November 13, 2024 11:59
@karianna karianna merged commit 800c802 into PCGen:master Nov 16, 2024
2 checks passed
@Vest Vest deleted the CODE-3531_refactoring branch November 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants