Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abr-testing): add deck riser parameter to protocols #16791

Merged
merged 54 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
cde88cb
increase google sheet columns
rclarke0 Jul 23, 2024
e534a8f
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 23, 2024
e200e8c
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 24, 2024
022dcb0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 24, 2024
0cbcd1b
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 25, 2024
9628c49
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 29, 2024
9f2d693
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 30, 2024
728c2e1
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Jul 31, 2024
31d0596
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 1, 2024
2bbcc3e
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 1, 2024
916f496
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 1, 2024
ebf6c72
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 2, 2024
56aa6dd
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 6, 2024
17cadc6
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 7, 2024
378ae28
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 9, 2024
68d6778
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 9, 2024
43fcb8a
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 13, 2024
7ed3f7d
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 13, 2024
7fda077
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 14, 2024
d40b067
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 20, 2024
0f0d482
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 20, 2024
02f92cb
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 22, 2024
a50bb16
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Aug 27, 2024
20a4087
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 3, 2024
3a5d003
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 5, 2024
4b80358
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 5, 2024
7dc9204
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 9, 2024
d7ee6d4
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 10, 2024
c9dfbf6
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 16, 2024
293ba96
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 16, 2024
be60ffb
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 18, 2024
9e2d7a5
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 18, 2024
083f7e3
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 19, 2024
9b5d48b
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 23, 2024
22a4520
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 24, 2024
59779d8
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 26, 2024
f5563f0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 27, 2024
c950b7b
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Sep 30, 2024
1842099
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 4, 2024
93f45a7
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 7, 2024
d3894d8
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 9, 2024
5704034
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 9, 2024
293803e
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 10, 2024
4c81aec
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 15, 2024
c8a29d0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 22, 2024
adcd2a9
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 23, 2024
8bfd478
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 23, 2024
a431735
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 23, 2024
6b460db
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 24, 2024
73107de
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 24, 2024
a030bcc
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Oct 25, 2024
77d46de
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Nov 8, 2024
f741379
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
rclarke0 Nov 13, 2024
57c5f11
create deck riser parameter
rclarke0 Nov 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def add_parameters(parameters: ParameterContext) -> None:
default=False,
)
helpers.create_disposable_lid_parameter(parameters)
helpers.create_tc_lid_deck_riser_parameter(parameters)
helpers.create_two_pipette_mount_parameters(parameters)
parameters.add_int(
variable_name="num_samples",
Expand Down Expand Up @@ -85,6 +86,7 @@ def run(ctx: ProtocolContext) -> None:
dry_run = ctx.params.dry_run # type: ignore[attr-defined]
pipette_1000_mount = ctx.params.pipette_mount_1 # type: ignore[attr-defined]
pipette_50_mount = ctx.params.pipette_mount_2 # type: ignore[attr-defined]
deck_riser = ctx.params.deck_riser # type: ignore[attr-defined]
REUSE_ETOH_TIPS = True
REUSE_RSB_TIPS = (
True # Reuse tips for RSB buffer (adding RSB, mixing, and transferring)
Expand Down Expand Up @@ -158,7 +160,7 @@ def run(ctx: ProtocolContext) -> None:
unused_lids: List[Labware] = []
# Load TC Lids
if disposable_lid:
unused_lids = helpers.load_disposable_lids(ctx, 5, ["C3"])
unused_lids = helpers.load_disposable_lids(ctx, 5, ["C3"], deck_riser)
# Import Global Variables

global tip50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,16 @@ def add_parameters(parameters: ParameterContext) -> None:
helpers.create_single_pipette_mount_parameter(parameters)
helpers.create_disposable_lid_parameter(parameters)
helpers.create_csv_parameter(parameters)
helpers.create_tc_lid_deck_riser_parameter(parameters)


def run(ctx: ProtocolContext) -> None:
"""Protocol."""
pipette_mount = ctx.params.pipette_mount # type: ignore[attr-defined]
disposable_lid = ctx.params.disposable_lid # type: ignore[attr-defined]
parsed_csv = ctx.params.parameters_csv.parse_as_csv() # type: ignore[attr-defined]
deck_riser = ctx.params.deck_riser # type: ignore[attr-defined]

rxn_vol = 50
real_mode = True
# DECK SETUP AND LABWARE
Expand Down Expand Up @@ -60,7 +63,7 @@ def run(ctx: ProtocolContext) -> None:

# Opentrons tough pcr auto sealing lids
if disposable_lid:
unused_lids = helpers.load_disposable_lids(ctx, 3, ["C3"])
unused_lids = helpers.load_disposable_lids(ctx, 3, ["C3"], deck_riser)
used_lids: List[Labware] = []

# LOAD PIPETTES
Expand Down Expand Up @@ -205,4 +208,6 @@ def run(ctx: ProtocolContext) -> None:
ctx.move_labware(lid_on_plate, "C2", use_gripper=True)
else:
ctx.move_labware(lid_on_plate, used_lids[-2], use_gripper=True)
p50.drop_tip()
p50.configure_nozzle_layout(style=SINGLE, start="A1", tip_racks=tiprack_50)
helpers.find_liquid_height_of_all_wells(ctx, p50, wells_to_probe_flattened)
Original file line number Diff line number Diff line change
Expand Up @@ -340,5 +340,4 @@ def run(ctx: ProtocolContext) -> None:
)

current += 1
print(wells_with_liquids)
helpers.find_liquid_height_of_all_wells(ctx, p50, wells_with_liquids)
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ def add_parameters(parameters: ParameterContext) -> None:
helpers.create_tip_size_parameter(parameters)
helpers.create_dot_bottom_parameter(parameters)
helpers.create_disposable_lid_parameter(parameters)
helpers.create_tc_lid_deck_riser_parameter(parameters)


def run(ctx: ProtocolContext) -> None:
"""Protocol."""
b = ctx.params.dot_bottom # type: ignore[attr-defined]
TIPRACK_96_NAME = ctx.params.tip_size # type: ignore[attr-defined]
disposable_lid = ctx.params.disposable_lid # type: ignore[attr-defined]
deck_riser = ctx.params.deck_riser # type: ignore[attr-defined]

waste_chute = ctx.load_waste_chute()

Expand All @@ -61,7 +63,7 @@ def run(ctx: ProtocolContext) -> None:
helpers.temp_str, "C1"
) # type: ignore[assignment]
if disposable_lid:
unused_lids = helpers.load_disposable_lids(ctx, 3, ["A4"])
unused_lids = helpers.load_disposable_lids(ctx, 3, ["A4"], deck_riser)
used_lids: List[Labware] = []
thermocycler.open_lid()
h_s.open_labware_latch()
Expand Down

This file was deleted.

38 changes: 30 additions & 8 deletions abr-testing/abr_testing/protocols/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,24 @@ def load_common_liquid_setup_labware_and_instruments(


def load_disposable_lids(
protocol: ProtocolContext, num_of_lids: int, deck_slot: List[str]
protocol: ProtocolContext,
num_of_lids: int,
deck_slot: List[str],
deck_riser: bool = False,
) -> List[Labware]:
"""Load Stack of Disposable lids."""
unused_lids = [
protocol.load_labware("opentrons_tough_pcr_auto_sealing_lid", deck_slot[0])
]
if deck_riser:
deck_riser_adapter = protocol.load_adapter(
"opentrons_flex_deck_riser", deck_slot[0]
)
unused_lids = [
deck_riser_adapter.load_labware("opentrons_tough_pcr_auto_sealing_lid")
]
else:
unused_lids = [
protocol.load_labware("opentrons_tough_pcr_auto_sealing_lid", deck_slot[0])
]

if len(deck_slot) == 1:
for i in range(num_of_lids - 1):
unused_lids.append(
Expand Down Expand Up @@ -152,6 +164,16 @@ def create_disposable_lid_parameter(parameters: ParameterContext) -> None:
)


def create_tc_lid_deck_riser_parameter(parameters: ParameterContext) -> None:
"""Create parameter for tc lid deck riser."""
parameters.add_bool(
variable_name="deck_riser",
display_name="Deck Riser",
description="True means use deck riser.",
default=False,
)


def create_tip_size_parameter(parameters: ParameterContext) -> None:
"""Create parameter for tip size."""
parameters.add_str(
Expand Down Expand Up @@ -334,10 +356,10 @@ def find_liquid_height_of_all_wells(
"""Find the liquid height of all wells in protocol."""
dict_of_labware_heights = {}
pipette.pick_up_tip()
pip_channels = pipette.active_channels
for well in wells:
labware_name = well.parent.load_name
total_number_of_wells_in_plate = len(well.parent.wells())
pip_channels = pipette.active_channels
# if pip_channels is > 1 and total_wells > 12 - only probe 1st row.
if (
pip_channels > 1
Expand All @@ -349,11 +371,11 @@ def find_liquid_height_of_all_wells(
elif total_number_of_wells_in_plate <= 12:
liquid_height_of_well = find_liquid_height(pipette, well)
dict_of_labware_heights[labware_name, well] = liquid_height_of_well
if pip_channels == pipette.channels:
if pip_channels != pipette.channels:
pipette.drop_tip()
else:
pipette.return_tip()
pipette.reset_tipracks()
else:
pipette.drop_tip()
msg = f"result: {dict_of_labware_heights}"
protocol.comment(msg=msg)
return dict_of_labware_heights
Expand Down
Loading