Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abr-testing): add deck riser parameter to protocols #16791

Merged
merged 54 commits into from
Nov 13, 2024
Merged

feat(abr-testing): add deck riser parameter to protocols #16791

merged 54 commits into from
Nov 13, 2024

Conversation

rclarke0
Copy link
Contributor

Overview

Added deck riser parameter to ABR protocols disposable lids.

Test Plan and Hands on Testing

  • ran make simulate with parameter set to True and False

Changelog

  • added parameter to helpers file
  • added parameter to all files with tc lids
  • removed 9_parameters.csv since it no longer uses csv file
  • removed print statements in ABR3 protocol
  • fixed bug in ABR2 protocol causing robot to end with tip attached.

Review requests

Risk assessment

@rclarke0
increase google sheet columns
cde88cb
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
e534a8f
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
e200e8c
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
022dcb0
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
0cbcd1b
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9628c49
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9f2d693
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
728c2e1
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
31d0596
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
2bbcc3e
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
916f496
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
ebf6c72
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
56aa6dd
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
17cadc6
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
378ae28
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
68d6778
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
43fcb8a
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7ed3f7d
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7fda077
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
d40b067
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
0f0d482
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
02f92cb
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a50bb16
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
20a4087
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
3a5d003
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
4b80358
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7dc9204
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
d7ee6d4
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
c9dfbf6
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
293ba96
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
be60ffb
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9e2d7a5
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
083f7e3
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9b5d48b
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
22a4520
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
59779d8
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
f5563f0
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
c950b7b
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
1842099
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
93f45a7
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
d3894d8
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
5704034
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
293803e
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
4c81aec
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
c8a29d0
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
adcd2a9
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
8bfd478
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a431735
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
6b460db
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
73107de
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a030bcc
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
77d46de
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
f741379
@rclarke0
create deck riser parameter
57c5f11
@rclarke0 rclarke0 requested review from a team as code owners November 13, 2024 16:34
AnthonyNASC20
AnthonyNASC20 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@AnthonyNASC20 AnthonyNASC20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rclarke0 rclarke0 merged commit 04031f3 into edge Nov 13, 2024
40 checks passed
@rclarke0 rclarke0 deleted the abr-add-deck-riser branch November 13, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyNASC20 AnthonyNASC20 AnthonyNASC20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclarke0 @AnthonyNASC20