refactor(app): add modal mixed media content #15373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
force-pushed
the
exec-489-add-mixed-content
branch
3 times, most recently
from
79f6927
to
4f93543
Compare
This is a component for InterventionModal (and eventually the rest of the kinds of modal) that presents some kind of selectable visual element - spinner, icon context, image - and some text. Implemented for both the desktop and ODD. Closes EXEC-489
sfoster1
force-pushed
the
exec-489-add-mixed-content
branch
from
abac4c2
to
8e82f7b
Compare
nbshiland
pushed a commit
that referenced
this pull request
Jun 25, 2024
This is a component for InterventionModal (and eventually the rest of the kinds of modal) that presents some kind of selectable visual element - spinner, icon, image - and some text. Implements https://www.figma.com/design/8dMeu8MuPfXoORtOV6cACO/Feature%3A-Error-Recovery?node-id=1935-44819&t=pKbR40CZeBMrPLxM-4 Storybook: https://s3-us-west-2.amazonaws.com/opentrons-components/exec-489-add-mixed-content/index.html?path=/docs/app-molecules-interventionmodal-modalcontentmixed--docs Closes EXEC-489
sfoster1
added a commit
that referenced
this pull request
Jun 27, 2024
Implements the Description modal content component for ODD and Desktop. Also updates `InlineNotification` to have corresponding desktop styles using the new `StyledText`, which means it doesn't have to be ODD only anymore so pop its stories over to `App`. Note - can't be merged until #15373 is merged because it needs the StyledText fixes from there. Closes EXEC-491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a component for InterventionModal (and eventually the rest of the kinds of modal) that presents some kind of selectable visual element
Implements https://www.figma.com/design/8dMeu8MuPfXoORtOV6cACO/Feature%3A-Error-Recovery?node-id=1935-44819&t=pKbR40CZeBMrPLxM-4
Storybook: https://s3-us-west-2.amazonaws.com/opentrons-components/exec-489-add-mixed-content/index.html?path=/docs/app-molecules-interventionmodal-modalcontentmixed--docs
Closes EXEC-489