refactor(app): InterventionModal Description component #15446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
changed the title
sfoster1
force-pushed
the
exec-489-add-mixed-content
branch
from
abac4c2
to
8e82f7b
Compare
sfoster1
force-pushed
the
EXEC-491-description-component
branch
from
0447dc6
to
d92d5a7
Compare
This is a component that will be used in error recovery. Closes EXEC-491
It can be used on desktop too now, isn't that fancy The br with display-none is a little gross, but it lets us keep the horizontal style with text layout rules on ODD and have it on two lines on desktop.
sfoster1
force-pushed
the
EXEC-491-description-component
branch
from
d92d5a7
to
b449094
Compare
| )} | ||
| {onCloseClick && ( | ||
| <Btn | ||
| data-testid="InlineNotification_close-button" |
There was a problem hiding this comment.
for what are we using this? just wondering why we have this arg
TamarZanzouri
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Description modal content component for ODD and Desktop.
Also updates
InlineNotificationto have corresponding desktop styles using the newStyledText, which means it doesn't have to be ODD only anymore so pop its stories over toApp.Note - can't be merged until #15373 is merged because it needs the StyledText fixes from there.