Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc/feat: slotless page templates #376

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaljarv
Copy link
Contributor

@kaljarv kaljarv commented Feb 24, 2024

WHY:

Fixes #375

What has been changed (if possible, add screenshots, gifs, etc. )

This PR is a PoC draft. Go to onto the /_test route to see the slotless layout in action. Note that it doesn't yet attempt to fully recreate the actual layouts.

Some remarks:

  • The context used is just for testing and does not adhere to the future VoterContexts etc. (see: poc/refactor: data api and state management #573)
  • Instead of a PageConfig component, pages could just directly access the relevant context methods.
  • We might need something more involved instead of a HeaderActions component if we wanted to allow Svelte layouts to add items to the header that would be there on all subpages, i.e. /foo/+layout.svelte could add a Foo button that would be on all subpages, and /foo/bar/+page.svelte could add a Bar button so that both would be shown.

Check off each of the following tasks as they are completed

  • I have reviewed the changes myself in this PR. Please check the self-review document
  • I have added or edited unit tests.
  • I have run the unit tests successfully.
  • I have tested this change on my own device.
  • I have tested this change on other devices (Using Browserstack is recommended).
  • I have tested my changes using the WAVE extension
  • I have added documentation where necessary.
  • Is there an existing issue linked to this PR?

Clean up your git commit history before submitting the pull request!

@kaljarv kaljarv added type: feature New feature or request type: refactoring Refactoring the code without changing the functionality type: Svelte Component labels Feb 24, 2024
@kaljarv kaljarv self-assigned this Feb 24, 2024
@kaljarv kaljarv changed the title feat: slotless page templates poc/feat: slotless page templates Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request type: refactoring Refactoring the code without changing the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: slotless page templates
3 participants