Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slotless page templates #375

Open
kaljarv opened this issue Feb 24, 2024 · 0 comments · May be fixed by #376
Open

feat: slotless page templates #375

kaljarv opened this issue Feb 24, 2024 · 0 comments · May be fixed by #376
Assignees
Labels
status: epic An Epic, i.e. a feature larger than a single user story. Not intended to be tackled in one P type: feature New feature or request type: refactoring Refactoring the code without changing the functionality

Comments

@kaljarv
Copy link
Contributor

kaljarv commented Feb 24, 2024

The current page templates have some drawbacks, because they always re-render the whole page:

  • This prevents nice transitions between pages, and is possibly heavier for the frontend
  • This prevents supplying parts of the page in layouts, such as having an outer layout that includes the Logout button for in case of the Candidate App or the correct navigation menu.

The current templates have slots to facilitate placement of elements in different parts of the page. This can, however, be achieved by using a CSS grid layout for the page and use components for the different parts that define in which (named) grid area they are placed.

Additionally, this also allows us to control the order of the elements for screen readers such that the secondary actions on the top-right do not have to appear before the main content in the hierarchy if we so wish.

For the progress indicator provided by the templates can be implemented as a store (or a context).

Also, ensure that CLS issues are resolved.

@kaljarv kaljarv added type: feature New feature or request type: refactoring Refactoring the code without changing the functionality type: Svelte Component labels Feb 24, 2024
@kaljarv kaljarv linked a pull request Feb 24, 2024 that will close this issue
8 tasks
@kaljarv kaljarv added the status: epic An Epic, i.e. a feature larger than a single user story. Not intended to be tackled in one P label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: epic An Epic, i.e. a feature larger than a single user story. Not intended to be tackled in one P type: feature New feature or request type: refactoring Refactoring the code without changing the functionality
Projects
Status: Not implemented
Development

Successfully merging a pull request may close this issue.

3 participants