Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: question route #540

Open
kaljarv opened this issue May 31, 2024 · 0 comments
Open

refactor: question route #540

kaljarv opened this issue May 31, 2024 · 0 comments
Labels
scope: whole app All activities that concer the whole application type: refactoring Refactoring the code without changing the functionality

Comments

@kaljarv
Copy link
Contributor

kaljarv commented May 31, 2024

The page displaying a single question needs a rework. Note, though, that slotless page templates (#375) and app state management (#536) will have effects on this.

  • Split this into parts so that it can be more easily used in the Candidate App
  • Especially separate the category intro and the question display
  • Refactor the update logic which now happens inside updateQuestion, possibly to a different stream that filters and orders the available questions and another one dependent on that and the questionId route param that selects the question to display.
@norppaa norppaa added type: refactoring Refactoring the code without changing the functionality scope: whole app All activities that concer the whole application labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: whole app All activities that concer the whole application type: refactoring Refactoring the code without changing the functionality
Projects
None yet
Development

No branches or pull requests

2 participants