Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix models & add rudimentary validation #84

Merged

Conversation

jsangmeister
Copy link
Contributor

rudimentary implementation of #49, so at least the CI validation can be enabled again. Also prevents relation errors as the ones fixed in this PR. Changes are needed for OpenSlides/openslides-backend#2337

@jsangmeister jsangmeister added the enhancement General enhancement which is neither bug nor feature label Apr 18, 2024
@jsangmeister jsangmeister added this to the 4.x milestone Apr 18, 2024
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a new generated schema_relational.sql

dev/src/validate.py Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
models.yml Outdated Show resolved Hide resolved
@r-peschke r-peschke assigned jsangmeister and unassigned r-peschke Apr 18, 2024
@jsangmeister jsangmeister merged commit 936d185 into OpenSlides:feature/relational-db Apr 19, 2024
1 check passed
@jsangmeister jsangmeister deleted the fix-models branch April 19, 2024 06:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants