Adapt validate.py for new fields #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-adapt-validate-py
luisa-beerboom
force-pushed
the
49-adapt-validate-py
branch
from
cc57ca7
to
94a5027
Compare
|
Talked about it and decided to close in favor of #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Couldn't find documentation about what rules relate to the new fields, so I laboured under the assumption that everything in the models.yml was formatted correctly. I doubt that this is actually the case since I also found some type errors in it which I haven't fixed.
Based on what I saw in the models.yml I made the following assumptions about the new rules, which I am unsure about:
to,referenceandsqltoorsqlI have no idea how the
uniqueattribute that was hinted at is supposed to work as it is no where in the models.yml, so I didn't build in anything related to that for now@r-peschke can you give some more information?