Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model generation to relational models.yml #2337

Conversation

jsangmeister
Copy link
Contributor

part of #2311

cli/generate_models.py Outdated Show resolved Hide resolved
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As first step use the recommendation for checking field or not field. But I think we will replace this by functionality from the generation of relational db schema.

@jsangmeister
Copy link
Contributor Author

Tests are failing because motion/identical_motion_ids is still modelled as a number[] field because the current generate script cannot handle this case. This has to be changed before the tests here can succeed.

@r-peschke r-peschke assigned jsangmeister and unassigned r-peschke Apr 19, 2024
@jsangmeister jsangmeister merged commit 819fe4b into OpenSlides:feature/relational-db Apr 19, 2024
5 checks passed
@jsangmeister jsangmeister deleted the update-models-generation branch April 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants