Allow setting/disabling Emergency Stop during setup/via Serial commands #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title: Allow setting/disabling Emergency Stop during setup/via Serial commands Date: April 19th 2024 Co-Authored-By: nullstalgia <[email protected]>
This was referenced Aug 23, 2024
Cpp-Linter Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows enabling/disabling EStop without needing to change the compile-time constant.
Default pin is still obtained via
OPENSHOCK_ESTOP_PINUsing a pin of 0 (
GPIO_INVALIDin Common.h) in either the Captive Portal or via Serial will disable the EStop manager.Remaining tasks:
Original PR: #228 by @nullstalgia