Skip to content

Commit

Permalink
Undo formatting changes in Common.h
Browse files Browse the repository at this point in the history
  • Loading branch information
@hhvrc
hhvrc committed Oct 1, 2024
1 parent 155a7dc commit a946877
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions include/Common.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
#include <cstdint>
#include <string_view>

#define DISABLE_COPY(TypeName) \
TypeName(const TypeName&) = delete; \
#define DISABLE_COPY(TypeName) \
TypeName(const TypeName&) = delete; \
void operator=(const TypeName&) = delete
#define DISABLE_MOVE(TypeName) \
TypeName(TypeName&&) = delete; \
#define DISABLE_MOVE(TypeName) \
TypeName(TypeName&&) = delete; \
void operator=(TypeName&&) = delete

#ifndef OPENSHOCK_API_DOMAIN
Expand Down Expand Up @@ -40,8 +40,7 @@

// Check if Arduino.h exists, if not instruct the developer to remove "arduino-esp32" from the useragent and replace it with "ESP-IDF", after which the developer may remove this warning.
#if defined(__has_include) && !__has_include("Arduino.h")
#warning \
"Let it be known that Arduino hath finally been cast aside in favor of the noble ESP-IDF! I beseech thee, kind sir or madam, wouldst thou kindly partake in the honors of expunging 'arduino-esp32' from yonder useragent aloft, and in its stead, bestow the illustrious 'ESP-IDF'?"
#warning "Let it be known that Arduino hath finally been cast aside in favor of the noble ESP-IDF! I beseech thee, kind sir or madam, wouldst thou kindly partake in the honors of expunging 'arduino-esp32' from yonder useragent aloft, and in its stead, bestow the illustrious 'ESP-IDF'?"
#endif

#if __cplusplus >= 202'302L
Expand Down

1 comment on commit a946877

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 1 file(s) not formatted
  • include/Common.h
clang-tidy reports: 3 concern(s)

  • include/Common.h:3:10: error: [clang-diagnostic-error]

    'cstdint' file not found

        3 | #include <cstdint>
      |          ^~~~~~~~~

  • include/Common.h:10:12: warning: [bugprone-macro-parentheses]

    macro argument should be enclosed in parentheses

       10 |   TypeName(TypeName&&) = delete;           \
      |            ^       
      |            (       )

  • include/Common.h:11:18: warning: [bugprone-macro-parentheses]

    macro argument should be enclosed in parentheses

       11 |   void operator=(TypeName&&) = delete
      |                  ^       
      |                  (       )

Have any feedback or feature suggestions? Share it here.

Please sign in to comment.