PHP 8.5 support #4891
Merged
PHP 8.5 support #4891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addison74
previously approved these changes
Jul 21, 2025
# Conflicts: # composer.lock
|
# Conflicts: # composer.lock
# Conflicts: # composer.lock
- moved all patches from https://github.com/OpenMage/composer-patches to ".vendor-patches"
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for PHP 8.5 in the OpenMage/magento-lts project by updating version constraints, dependencies, and configuration files to handle PHP 8.5 compatibility.
- Updated PHP version constraint from
<8.5to<8.6in composer.json to support PHP 8.5 - Added PHP 8.5 polyfill dependency and updated Symfony polyfill versions to ^1.33
- Migrated patch references from remote URLs to local
.vendor-patchesfiles for better maintainability
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/content/users/requirements.md | Updated documentation to indicate PHP 8.4/8.5 support |
| composer.json | Expanded PHP version constraint, updated polyfill dependencies, and migrated to local patch files |
| .phpstan.dist.neon | Updated PHPStan max PHP version to 80599 (PHP 8.5) |
| .rector.php | Added PHP 8.5 Rector rules for code modernization |
| .github/workflows/syntax-php.yml | Updated CI matrix to test PHP 8.5 instead of 8.4 |
| .github/workflows/phpunit.yml | Updated CI matrix to test PHP 8.5 instead of 8.4 |
| .ddev/commands/web/vendor-patches | Added patches folder parameter to vendor-patches command |
| Multiple .vendor-patches/*.patch files | Local patch files for various dependencies and bug fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
addison74
previously approved these changes
Oct 1, 2025
kiatng
reviewed
Oct 2, 2025
Hanmac
previously approved these changes
Oct 2, 2025
# Conflicts: # composer.lock
|
|
We already had two green flags ... merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions or comments
phpstan errors are fixed in #4889